Skip to content

[6.0][Preset] Disable verify dwarf for toolchain preset #72602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

shahmishal
Copy link
Member

Explanation: The macOS toolchain bot has gotten slower due to dwarf verifier with assertion enabled.

extract symbols phase has increased by 260%:

  • macosx-x86_64-extractsymbols 832.14s (5.10) -> 2992.12s (main and release/6.0)
  • macosx-arm64-extractsymbols 746.63s (5.10) -> 2728.38s (main and release/6.0)

Issue: rdar://124988302
Original PR: #72496
Risk: Low
Testing: Verify via building the toolchain on macOS
Reviewer: @edymtt

@shahmishal shahmishal requested a review from a team as a code owner March 26, 2024 23:16
@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author

@swift-ci build toolchain macOS

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author

@swift-ci build toolchain macOS

@shahmishal
Copy link
Member Author

6.0%              	 904.64                	 macosx-arm64-extractsymbols
5.8%              	 884.09                	 macosx-x86_64-extractsymbols

@shahmishal shahmishal merged commit e1ca80a into release/6.0 Mar 27, 2024
@shahmishal shahmishal deleted the disable-verify-dwarf-swift-6.0 branch March 27, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants