Skip to content

Fix LifetimeDependenceDefUseWalker for address yields. #72764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 2, 2024

Do not treat address yields as escapes.

Fixes rdar://125752476 (UnsafeRawPointer property in non-escapable type doesn't compile)

atrick added 4 commits April 1, 2024 21:46
These core utils did not handle UnconditionalCheckedCastAddrInst or
UncheckedRefCastAddrInst correctly.
It is not a SingleValueInstruction.
Do not treat address yields as escapes.

Fixes rdar://125752476 (`UnsafeRawPointer` property in non-escapable type doesn't compile)
@atrick atrick requested a review from meg-gupta April 2, 2024 05:17
@atrick atrick requested a review from eeckstein as a code owner April 2, 2024 05:17
@atrick
Copy link
Contributor Author

atrick commented Apr 2, 2024

@swift-ci test

@atrick atrick merged commit 44a2661 into swiftlang:main Apr 2, 2024
@atrick atrick deleted the fix-address-yield branch April 2, 2024 15:33
Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants