[6.0] LifetimeDependence: handle dependent values in throwing calls. #72839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
(cherry picked from commit 89063c9)
Fixes rdar://125564278 (~Escapable: crash in LifetimeDependenceInsertion) (cherry picked from commit fbae21f)
(cherry picked from commit bac1dc9)
drop_deinit forwards ownership while effectively stripping the deinitializer. It is similar to a type cast. Fixes rdar://125590074 ([NonescapableTypes] Nonescapable types cannot have deinits) (cherry picked from commit 581010d)
atrick
force-pushed
the
60-fix-lifedep-throw
branch
from
b5459b1 to
2e3e85d
Compare
|
@swift-ci test |
tbkka
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased onto #72768
--- CCC ---
Explanation: Fix LifetimeDependenceDiagnostics to handle dependent values in throwing calls
Scope: Allows NonescapableTypes to be used with throwing calls and struct deinits.
Radar/SR Issues:
rdar://125564278 (~Escapable: crash in LifetimeDependenceInsertion)
rdar://125590074 ([NonescapableTypes] Nonescapable types cannot have deinits)
Original PR: #72777
Risk: This allows compiler passes to understand that the drop_deinit SIL instruction forwards its operand. This could increase the power of some optimizations in the presence of noncopyable types; however, I audited the code and did not see any places where that would be risky.
Testing: Unit tests added
Reviewer: @meg-gupta