Skip to content

[Lexer] Fix an assertion failure when invoking code completion inside a single-quoted string literal #73480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/Parse/Lexer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1832,6 +1832,12 @@ void Lexer::diagnoseSingleQuoteStringLiteral(const char *TokStart,
OutputPtr = Ptr;
// Escape double quotes.
replacement.append("\\\"");
} else if (Ptr[-1] == 0) {
// The string literal might contain a null byte if the code completion
// position is inside the string literal. Don't include the null byte in
// the replacement string.
replacement.append(OutputPtr, Ptr - 1);
OutputPtr = Ptr;
}
}
assert(Ptr == TokEnd && Ptr[-1] == '\'');
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
fileprivate enum BundleComponent {
// RUN: %sourcekitd-test -req=complete -pos=%(line + 1):25 %s -- %s
case swiftVersions = 's'
}