[6.0🍒] Switch Windows search path options to std::string #73549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A CompilerInvocation object may outlive the input argument list, so we need to copy these argument strings to avoid a use-after-free (cherry picked from commit 7c64093)
|
@swift-ci please test |
bnbarham
approved these changes
May 9, 2024
DougGregor
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: A CompilerInvocation object may outlive the input argument list, so we need to copy these argument strings to avoid a use-after-free
Scope: This fixes a crash in sourcekit-lsp that occurs when any of these flags are present in
compile_commands.jsonIssue: swiftlang/sourcekit-lsp#1167
Risk: Very low. There is a (almost negligible) bump in memory usage to store copies of these strings. This change will only impact builds on Windows that specify these flags.
Testing: I've tested this patch locally and no longer see sourcekit-lsp crashing with the patch.
Reviewer: @compnerd @ahoppen
(cherry picked from commit 7c64093)