[Dependency Scanning] Collect and report each module dependency's Link Libraries #73907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
ExplicitAutoLinkScanner
branch
from
2b24dae to
51fb270
Compare
artemcm
requested review from
hborla,
slavapestov,
xedin,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder and
tshortli
as code owners
ian-twilightcoder
approved these changes
May 28, 2024
| std::function<void(const LinkLibrary&)> RegistrationCallback) { | ||
| if (Target.isOSDarwin()) | ||
| RegistrationCallback(LinkLibrary("c++", LibraryKind::Library)); | ||
| else if (Target.isOSLinux()) |
There was a problem hiding this comment.
I thought Android used libc++ and not libstdc++?
There was a problem hiding this comment.
The core logic here just moved from how it was in GenDecl.cpp. But @egorzhdan may know the answer.
artemcm
force-pushed
the
ExplicitAutoLinkScanner
branch
2 times, most recently
from
4fd42c8 to
04191c2
Compare
artemcm
force-pushed
the
ExplicitAutoLinkScanner
branch
from
04191c2 to
6f5751a
Compare
There was a problem hiding this comment.
What do you think about the idea that forceLinked library should be pass to linker as full path so linker will not drop it when nothing from it is referenced? (Might need to check linker semantics for all the supported platforms/linkers). Then we can drop FORCE_LINK symbols too when explicit auto link is used.
| @@ -93,12 +95,10 @@ struct ModuleDependencyID { | |||
| std::string ModuleName; | |||
| ModuleDependencyKind Kind; | |||
| bool operator==(const ModuleDependencyID &Other) const { | |||
| return std::tie(ModuleName, Kind) == | |||
| std::tie(Other.ModuleName, Other.Kind); | |||
| return std::tie(ModuleName, Kind) == std::tie(Other.ModuleName, Other.Kind); | |||
There was a problem hiding this comment.
Nit: avoid re-formatting unchanged logic. This makes review and git blame hard.
artemcm
force-pushed
the
ExplicitAutoLinkScanner
branch
from
6f5751a to
d064d30
Compare
artemcm
force-pushed
the
ExplicitAutoLinkScanner
branch
from
d064d30 to
d708635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.