Remove RemoteInspection code to fetch no-longer-used reflection metadata #74394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without relying on spare bit information in the reflection metadata (which was added in swiftlang#40906). As a result, we can remove the code from swiftlang#40906. This is the first step in such removal. It removes the RemoteMirror code for looking up such metadata. It leaves behind: * Sufficient stubs for LLDB to continue to build. Once LLDB is updated, these stubs can be removed as well. * The compiler code to emit such metadata. This allows new binaries to still reflect MPEs on older runtimes. This will need to be kept for a transitional period.
|
@swift-ci Please test |
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Jun 14, 2024
PR swiftlang#74394 removed a field from `struct MetadataSections` whose layout is ABI. So restore that field as an unused padding field to preserve the layout of all the other fields in that struct.
Merged
|
Reverted in #74439 because it broke ABI and resulted in errors in "accessible functions" (which happens to be the linker section immediately after mpenum in several data structures). |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Jun 20, 2024
PR swiftlang#74394 removed a field from `struct MetadataSections` whose layout is ABI. So restore that field as an unused padding field to preserve the layout of all the other fields in that struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs #74145 and #73491 updated RemoteMirror to reflect Multi-Payload Enums (MPEs) without relying on spare bit information in the reflection metadata. This means we can remove the additional metadata that was added in #40906.
This is the first step in such removal. It removes most of the remaining RemoteMirror code for looking up such metadata. It leaves behind:
Sufficient stubs for LLDB to continue to build. Once LLDB is updated, these stubs can be removed as well.
The compiler code to emit such metadata. This allows new binaries to still reflect MPEs on older runtimes. This will need to be kept for a transitional period.
(This was excerpted from #74230 after discussion there. That will be updated for the tasks above after this lands.)