[Dependency Scanning] Emit diagnostics on scan query failure during initialization or cycle detection #75111
Conversation
artemcm
force-pushed
the
ScannerFailureMinimalDiagnostics
branch
4 times, most recently
from
354d402 to
c67ee46
Compare
|
@swift-ci test |
artemcm
changed the title
| // Generate an instance of the `swiftscan_dependency_graph_s` which contains no | ||
| // module dependnecies but captures the diagnostics emitted during the attempted | ||
| // scan query. | ||
| static swiftscan_dependency_graph_t generateHollowDiagnosticOutput( |
There was a problem hiding this comment.
will this be easier and cleaner to do by constructing an empty ModuleDependencyInfo then convert that into scanner object?
There was a problem hiding this comment.
The code for creating an swiftscan_dependency_info_t from a ModuleDependencyInfo now relies on a ready-populated scanner cache, for example, and a successfully-constructed compilation instance, along with other assumptions, in generateFullDependencyGraph.
It can certainly be refactored to support this use-case as well, and it'd probably be overall cleaner, but I wanted to restrict this change in scope to minimally affect the non-error code-path, since I'd like to get this change into 6.0.
I think this may be a good follow-up change to do on main.
1 similar comment
artemcm
force-pushed
the
ScannerFailureMinimalDiagnostics
branch
from
c67ee46 to
f72d70b
Compare
…arry diagnostic output
artemcm
force-pushed
the
ScannerFailureMinimalDiagnostics
branch
from
f72d70b to
a47bf36
Compare
On dependency scan failure query, ensure any diagnostics that the compiler has accumulated along the way are still produced to the client.
For example, if scan query compilation instance initialization fails on an unknown argument to the frontend, the unknown argument diagnostic will be captured, and returned to the client.
Or, on encountering a dependency cycle, instead of returning an error to the client, a hollow result object is constructed carrying the diagnostic error state.
Resolves rdar://130897498