-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[windows][build.ps1] only use swift-corelibs-foundation-windows checkout #75140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
in CI swiftlang#75073 has broken a local toolchain build on windows using build.ps1, as the local build does not use update_checkout on windows, and thus does not checkout swift-corelibs-foundation-windows.
@swift-ci please test |
@swift-ci please build windows toolchain |
CC: @iCharlesHu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a decent workaround, though would be nice to track the removal of this once swift-corelibs-foundation is universally re-cored.
# a checkout that does not yet use swift-foundation. | ||
$RepoName = "swift-corelibs-foundation-windows"; | ||
} else { | ||
$RepoName = "swift-corelibs-foundation"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does the script that specifies swift-corelibs-foundation
for local builds live? Is it currently checking out main
or windows/main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is at https://github.com/compnerd/swift-build/blob/main/default.xml#L20. It should checkout windows/main
for now and will need to be changed back to main
once main restores the ability to build for Windows.
@swift-ci please build windows toolchain |
1 similar comment
@swift-ci please build windows toolchain |
@swift-ci please build toolchain |
in CI
#75073 has broken a local toolchain build on windows using build.ps1,
as the local build does not use update_checkout on windows, and thus does not checkout swift-corelibs-foundation-windows.