Skip to content

[cxx-interop] Implements CxxMutableSpan, created from an UnsafeMutableBufferPointer #75369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

[cxx-interop] Implements CxxMutableSpan, created from an UnsafeMutableBufferPointer #75369

merged 1 commit into from
Jul 19, 2024

Conversation

susmonteiro
Copy link
Contributor

  • Added tests for generic functions
  • Add some tests for mutable spans
  • Initialize ConstSpan from UnsafeMutableBufferPointer
  • Change hardening flag

@susmonteiro
[cxx-interop] Implements CxxMutableSpan, created from an UnsafeMutabl…
684e9eb 
…eBufferPointer

* Added tests for generic functions
* Add some tests for mutable spans
* Initialize ConstSpan from UnsafeMutableBufferPointer
* Change hardening flag
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jul 19, 2024
egorzhdan
egorzhdan approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@susmonteiro susmonteiro merged commit 2ab23ae into main Jul 19, 2024
3 checks passed
@susmonteiro susmonteiro deleted the susmonteiro/cxx-span-nonconst branch July 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susmonteiro @egorzhdan