[Backtracing] Implement API per SE-0419 #78516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
requested review from
jckarter,
rjmccall,
ahoppen,
bnbarham,
hamishknight,
rintaro,
mikeash,
a team,
artemcm,
tshortli,
MaxDesiatov,
etcwilde,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
|
@swift-ci Please test |
|
The first changeset, "Update module maps", is the subject of a separate PR. |
|
Hmmm. Looks like maybe my change to add |
al45tair
force-pushed
the
eng/PR-124913332
branch
2 times, most recently
from
468f648 to
01e2468
Compare
|
@swift-ci Please test |
al45tair
force-pushed
the
eng/PR-124913332
branch
3 times, most recently
from
7a1fdfc to
e360d99
Compare
|
@swift-ci Please test |
We're going to rename the module to Runtime, and it isn't going to be an implicit import, so we don't need any of this. rdar://124913332
Move the backtracing code into a new Runtime module. This means renaming the Swift Runtime's CMake target because otherwise there will be a name clash. rdar://124913332
al45tair
force-pushed
the
eng/PR-124913332
branch
from
b97df1d to
4a7ca68
Compare
|
@swift-ci Please test |
Remove a `-disable-implicit-backtracing-module-import` that was added in `Runtimes/Core/CMakeLists.txt`, and also remove the reference to `swiftCxxStdlib` from `RuntimeModule` as that causes the build to fail when attempting to build the static version of `swift-backtrace` on Linux. rdar://124913332
al45tair
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
We needed to add `--enable-runtime-module` in the Python test scripts. rdar://124913332
Also removed a spurious `print()` that got left in by accident, and disabled the `CodableBacktrace.swift` test on Linux since we need Foundation and we don't have it there. rdar://124913332
|
@swift-ci Please test |
|
This is still going to break because of the |
|
@swift-ci Please test |
If this test fails in CI, we could do with being able to see the output from the test program in full. rdar://124913332
|
@swift-ci Please test |
If we ended up with a `/` at the beginning of a string segment, we were erroneously not adding to the expansion dictionary when we should have been. rdar://124913332
|
@swift-ci Please test |
We only want to add the `swift-backtrace` binary dependency when the SDK we're looking at actually has `swift-backtrace` enabled. rdar://124913332
|
@swift-ci Please test |
weissi
reviewed
Jan 24, 2025
edymtt
reviewed
Jan 24, 2025
mikeash
approved these changes
Jan 24, 2025
It's useful to capture the platform and platform version with the image map. Also, display both the platform and architecture information when generating a crash log. rdar://124913332
Added some explanatory text to the Compact Backtrace Format documentation, and also to the `CMakeLists.txt` for the runtime. Tweaked the conversions for `Backtrace.Address` to truncate, which should result in reasonable behaviour for negative fixed-width integers. Use a constant for the ASCII values for `/` and `\` in the Compact Image Format encoder/decoder. Make the TSD key for `ElfImageCache` non-optional, and call `fatalError()` if we don't get one. rdar://124913332
|
@swift-ci Please test |
edymtt
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the API described in SE-0419, in a new module
Runtimethat you can import from your Swift program.Additionally, made symbolicated backtraces approximately 5x faster on Linux.
rdar://124913332