-
Notifications
You must be signed in to change notification settings - Fork 10.5k
🍒[6.1] Add a flag to dump the AST as JSON. #78955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
allevato
commented
Jan 27, 2025
- Explanation: Support dumping the AST in JSON format.
- Scope: This primarily only affects ASTDumper and the frontend interface (a new flag). It does not impact how code is compiled.
- Issues: N/A
- Original PRs: Add a flag to dump the AST as JSON. (Second version) #78463, as well as [AST] Dump decl attributes #77937 (@rintaro) to include attribute dumping.
- Risk: Low. This only affects ASTDumper.
- Testing: Lit tests from the original PR exercise the new feature.
- Reviewers: @hamishknight
@swift-ci please smoke test |
@swift-ci please test |
We need full (non-smoke) tests for the 6.1 branch, so I just kicked those off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with us taking this, but it does look like the Windows issue is a legitimate bug?
That test uses |
While I wait for my Windows build of the 6.1 branch to make progress, I'll work on updating the test to use its own macro instead of depending on one from stdlib. If that passes on all platforms, I can update |
@swift-ci please test |