-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Observation] Initial implementation of Observed for transactional tracked values over time #79817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
98d782f
d13c7aa
b39352e
52b36e7
855dfa8
c1b5278
6438ff4
534fb0f
508aedc
39df5db
6db5288
b05703a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,281 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
import _Concurrency | ||
|
||
@usableFromInline | ||
@available(SwiftStdlib 5.1, *) | ||
@_silgen_name("swift_task_addCancellationHandler") | ||
func _taskAddCancellationHandler(handler: () -> Void) -> UnsafeRawPointer /*CancellationNotificationStatusRecord*/ | ||
|
||
@usableFromInline | ||
@available(SwiftStdlib 5.1, *) | ||
@_silgen_name("swift_task_removeCancellationHandler") | ||
func _taskRemoveCancellationHandler( | ||
record: UnsafeRawPointer /*CancellationNotificationStatusRecord*/ | ||
) | ||
|
||
func withIsolatedTaskCancellationHandler<T: Sendable>( | ||
operation: @isolated(any) () async throws -> T, | ||
onCancel handler: @Sendable () -> Void, | ||
isolation: isolated (any Actor)? = #isolation | ||
) async rethrows -> T { | ||
// unconditionally add the cancellation record to the task. | ||
// if the task was already cancelled, it will be executed right away. | ||
let record = _taskAddCancellationHandler(handler: handler) | ||
defer { _taskRemoveCancellationHandler(record: record) } | ||
|
||
return try await operation() | ||
} | ||
|
||
/// An asychronous sequence generated from a closure that tracks the transactional changes of `@Observable` types. | ||
/// | ||
/// `Observations` conforms to `AsyncSequence`, providing a intutive and safe mechanism to track changes to | ||
/// types that are marked as `@Observable` by using Swift Concurrency to indicate transactional boundaries | ||
/// starting from the willSet of the first mutation to the next suspension point of the safe access. | ||
@available(SwiftStdlib 9999, *) | ||
public struct Observations<Element: Sendable, Failure: Error>: AsyncSequence, Sendable { | ||
public enum Iteration: Sendable { | ||
case next(Element) | ||
case finish | ||
} | ||
|
||
struct State { | ||
enum Continuation { | ||
case cancelled | ||
case active(UnsafeContinuation<Void, Never>) | ||
func resume() { | ||
switch self { | ||
case .cancelled: break | ||
case .active(let continuation): continuation.resume() | ||
} | ||
} | ||
} | ||
var id = 0 | ||
var continuations: [Int: Continuation] = [:] | ||
var dirty = false | ||
|
||
// create a generation id for the unique identification of the continuations | ||
// this allows the shared awaiting of the willSets. | ||
// Most likely, there wont be more than a handful of active iterations | ||
// so this only needs to be unique for those active iterations | ||
// that are in the process of calling next. | ||
static func generation(_ state: _ManagedCriticalState<State>) -> Int { | ||
state.withCriticalRegion { state in | ||
defer { state.id &+= 1 } | ||
return state.id | ||
} | ||
} | ||
|
||
// the cancellation of awaiting on willSet only ferries in resuming early | ||
// it is the responsability of the caller to check if the task is actually | ||
// cancelled after awaiting the willSet to act accordingly. | ||
static func cancel(_ state: _ManagedCriticalState<State>, id: Int) { | ||
state.withCriticalRegion { state in | ||
guard let continuation = state.continuations.removeValue(forKey: id) else { | ||
// if there was no continuation yet active (e.g. it was cancelled at | ||
// the start of the invocation, then put a tombstone in to gate that | ||
// resuming later | ||
state.continuations[id] = .cancelled | ||
return nil as Continuation? | ||
} | ||
return continuation | ||
}?.resume() | ||
} | ||
|
||
// fire off ALL awaiting willChange continuations such that they are no | ||
// longer pending. | ||
static func emitWillChange(_ state: _ManagedCriticalState<State>) { | ||
let continuations = state.withCriticalRegion { state in | ||
// if there are no continuations present then we have to set the state as dirty | ||
// else if this is uncondiitonally set the state might produce duplicate events | ||
// one for the dirty and one for the continuation. | ||
if state.continuations.count == 0 { | ||
state.dirty = true | ||
} | ||
defer { | ||
state.continuations.removeAll() | ||
} | ||
return state.continuations.values | ||
} | ||
for continuation in continuations { | ||
continuation.resume() | ||
} | ||
} | ||
|
||
// install a willChange continuation into the set of continuations | ||
// this must take a locally unique id (to the active calls of next) | ||
static func willChange(isolation iterationIsolation: isolated (any Actor)? = #isolation, state: _ManagedCriticalState<State>, id: Int) async { | ||
return await withUnsafeContinuation(isolation: iterationIsolation) { continuation in | ||
state.withCriticalRegion { state in | ||
defer { state.dirty = false } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. after thinking about this a bit more, it seems to me resetting the flag in this way may admit the same problem as before, albeit in a more convoluted manner:
hopefully there are no logical flaws there... i haven't tried to actually implement an example that exercises this scenario |
||
switch state.continuations[id] { | ||
case .cancelled: | ||
return continuation as UnsafeContinuation<Void, Never>? | ||
case .active: | ||
// the Iterator itself cannot be shared across isolations so any call to next that may share an id is a misbehavior | ||
// or an internal book-keeping failure | ||
fatalError("Iterator incorrectly shared across task isolations") | ||
case .none: | ||
if state.dirty { | ||
return continuation | ||
} else { | ||
state.continuations[id] = .active(continuation) | ||
return nil | ||
} | ||
} | ||
}?.resume() | ||
} | ||
} | ||
} | ||
|
||
// @isolated(any) closures cannot be composed and retain or forward their isolation | ||
// this basically would be replaced with `{ .next(elementProducer()) }` if that | ||
// were to become possible. | ||
enum Emit { | ||
case iteration(@isolated(any) @Sendable () throws(Failure) -> Iteration) | ||
case element(@isolated(any) @Sendable () throws(Failure) -> Element) | ||
|
||
var isolation: (any Actor)? { | ||
switch self { | ||
case .iteration(let closure): closure.isolation | ||
case .element(let closure): closure.isolation | ||
} | ||
} | ||
} | ||
|
||
let state: _ManagedCriticalState<State> | ||
let emit: Emit | ||
|
||
// internal funnel method for initialziation | ||
internal init(emit: Emit) { | ||
self.emit = emit | ||
self.state = _ManagedCriticalState(State()) | ||
} | ||
|
||
/// Constructs an asynchronous sequence for a given closure by tracking changes of `@Observable` types. | ||
/// | ||
/// The emit closure is responsible for extracting a value out of a single or many `@Observable` types. | ||
/// | ||
/// - Parameters: | ||
/// - isolation: The concurrency isolation domain of the caller. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: no longer appears to be a parameter |
||
/// - emit: A closure to generate an element for the sequence. | ||
public init( | ||
@_inheritActorContext _ emit: @escaping @isolated(any) @Sendable () throws(Failure) -> Element | ||
) { | ||
self.init(emit: .element(emit)) | ||
} | ||
|
||
/// Constructs an asynchronous sequence for a given closure by tracking changes of `@Observable` types. | ||
/// | ||
/// The emit closure is responsible for extracting a value out of a single or many `@Observable` types. This method | ||
/// continues to be invoked until the .finished option is returned or an error is thrown. | ||
/// | ||
/// - Parameters: | ||
/// - isolation: The concurrency isolation domain of the caller. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: this doesn't appear to be a parameter |
||
/// - emit: A closure to generate an element for the sequence. | ||
public static func untilFinished( | ||
@_inheritActorContext _ emit: @escaping @isolated(any) @Sendable () throws(Failure) -> Iteration | ||
) -> Observations<Element, Failure> { | ||
.init(emit: .iteration(emit)) | ||
} | ||
|
||
public struct Iterator: AsyncIteratorProtocol { | ||
// the state ivar serves two purposes: | ||
// 1) to store a critical region of state of the mutations | ||
// 2) to idenitify the termination of _this_ sequence | ||
var state: _ManagedCriticalState<State>? | ||
let emit: Emit | ||
var started = false | ||
|
||
// this is the primary implementation of the tracking | ||
// it is bound to be called on the specified isolation of the construction | ||
fileprivate static func trackEmission(isolation trackingIsolation: isolated (any Actor)?, state: _ManagedCriticalState<State>, emit: Emit) throws(Failure) -> Iteration { | ||
// this ferries in an intermediate form with Result to skip over `withObservationTracking` not handling errors being thrown | ||
// particularly this case is that the error is also an iteration state transition data point (it terminates the sequence) | ||
// so we need to hold that to get a chance to catch and clean-up | ||
let result = withObservationTracking { | ||
switch emit { | ||
case .element(let element): | ||
Result(catching: element).map { Iteration.next($0) } | ||
case .iteration(let iteration): | ||
Result(catching: iteration) | ||
} | ||
} onChange: { [state] in | ||
// resume all cases where the awaiting continuations are awaiting a willSet | ||
State.emitWillChange(state) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It appears this implementation can leak the For long-lived observers (e.g. watching a model for the entire process lifetime), that leak may be acceptable. In workloads where tasks start and cancel Have you explored adding a bit more bookkeeping—perhaps reference counting or a shared cancellation token—so that |
||
} | ||
return try result.get() | ||
} | ||
|
||
fileprivate mutating func terminate(throwing failure: Failure? = nil, id: Int) throws(Failure) -> Element? { | ||
// this is purely defensive to any leaking out of iteration generation ids | ||
state?.withCriticalRegion { state in | ||
state.continuations.removeValue(forKey: id) | ||
}?.resume() | ||
// flag the sequence as terminal by nil'ing out the state | ||
state = nil | ||
if let failure { | ||
throw failure | ||
} else { | ||
return nil | ||
} | ||
} | ||
|
||
fileprivate mutating func trackEmission(isolation iterationIsolation: isolated (any Actor)?, state: _ManagedCriticalState<State>, id: Int) async throws(Failure) -> Element? { | ||
guard !Task.isCancelled else { | ||
// the task was cancelled while awaiting a willChange so ensure a proper termination | ||
return try terminate(id: id) | ||
} | ||
// start by directly tracking the emission via a withObservation tracking on the isolation specified fro mthe init | ||
switch try await Iterator.trackEmission(isolation: emit.isolation, state: state, emit: emit) { | ||
case .finish: return try terminate(id: id) | ||
case .next(let element): return element | ||
} | ||
} | ||
|
||
public mutating func next(isolation iterationIsolation: isolated (any Actor)? = #isolation) async throws(Failure) -> Element? { | ||
// early exit if the sequence is terminal already | ||
guard let state else { return nil } | ||
// set up an id for this generation | ||
let id = State.generation(state) | ||
do { | ||
// there are two versions; | ||
// either the tracking has never yet started at all and we need to prime the pump for this specific iterator | ||
// or the tracking has already started and we are going to await a change | ||
if !started { | ||
started = true | ||
return try await trackEmission(isolation: iterationIsolation, state: state, id: id) | ||
} else { | ||
// wait for the willChange (and NOT the value itself) | ||
// since this is going to be on the isolation of the object (e.g. the isolation specified in the initialization) | ||
// this will mean our next await for the emission will ensure the suspension return of the willChange context | ||
// back to the trailing edges of the mutations. In short, this enables the transactionality bounded by the | ||
// isolation of the mutation. | ||
await withIsolatedTaskCancellationHandler(operation: { | ||
await State.willChange(isolation: iterationIsolation, state: state, id: id) | ||
}, onCancel: { | ||
// ensure to clean out our continuation uon cancellation | ||
State.cancel(state, id: id) | ||
}, isolation: iterationIsolation) | ||
return try await trackEmission(isolation: iterationIsolation, state: state, id: id) | ||
} | ||
} catch { | ||
// the user threw a failure in the closure so propigate that outwards and terminate the sequence | ||
return try terminate(throwing: error, id: id) | ||
} | ||
} | ||
} | ||
|
||
public func makeAsyncIterator() -> Iterator { | ||
Iterator(state: state, emit: emit) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of the reimplementation here? to carry the
@isolated(any)
annotation? what observable behavior is altered by this? does it prevent dynamic suspension when awaiting the operation?