Skip to content

Propagate sysroot to module loader subinvocation #80007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

hjyamauchi
Copy link
Contributor

To fix the Android build issue #79839

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test windows platform

@hjyamauchi hjyamauchi marked this pull request as ready for review March 14, 2025 15:45
@hjyamauchi hjyamauchi requested a review from compnerd March 14, 2025 15:46
@hjyamauchi
Copy link
Contributor Author

This is an alternative to #79840

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi hjyamauchi requested a review from compnerd March 14, 2025 21:20
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing along the sysroot to the module loading seems like the right thing.

@hjyamauchi hjyamauchi enabled auto-merge March 14, 2025 22:55
@hjyamauchi hjyamauchi merged commit 275a679 into swiftlang:main Mar 15, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants