Skip to content

Revert "utils: Update default Android SDKs in build.ps1" #80037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

compnerd
Copy link
Member

Reverts #79944

It is safe to default to all architectures. When building in PR testing mode, we can limit the architectures through build-windows-toolchain.bat. For nightly, we should build all the architectures.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

1 similar comment
@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

@compnerd compnerd merged commit ef1a1d1 into main Mar 16, 2025
3 checks passed
@compnerd compnerd deleted the revert-79944-windrd-update-default-sdks branch March 16, 2025 23:25
@weliveindetail
Copy link
Member

@compnerd This won't work, because we only have overrides for not-yet-supported tests for aarch64.

We could:

  1. Merge utils: temporarily ignore test failure for Android runtimes #80148 temporarily
  2. Revisit the failing tests the other arches in the logs
  3. Add overrides for them
  4. Revert the temporary change from 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants