AST: Quote attributes more consistently in diagnostics #80593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
slavapestov,
xedin,
kavon,
eeckstein,
jckarter,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
rjmccall,
ktoso and
nkcsgexi
as code owners
|
@swift-ci please smoke test macOS |
AnthonyLatsis
force-pushed
the
collybia-nuda
branch
from
4699502 to
be740f6
Compare
|
@swift-ci please smoke test macOS |
AnthonyLatsis
force-pushed
the
collybia-nuda
branch
from
be740f6 to
676f0e2
Compare
AnthonyLatsis
force-pushed
the
collybia-nuda
branch
from
676f0e2 to
ada632c
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are supposed to quote anything that is referred to as code, and attributes are no exception. Next, we need to move away from spelling them out in message templates.