6.2: [IRGen] Fix type of deleted coro error func. #80606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously erroneously an async function pointer. Also fix the name.
|
@swift-ci please test |
|
@swift-ci please test linux platform |
tbkka
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix link entity kind for
swift_deletedCalleeAllocatedCoroutineMethodError.When methods are eliminated from wtables/vtables, they need to be replaced with something. In the case of async functions, that's
swift_deletedAsyncMethodError--when an async method is deleted, a pointer to the async function pointer ofswift_deletedAsyncMethodErroris put into the wtable/vtable. An analogous consideration applies to callee-allocated coroutines: when they're deleted from vtables/wtables, they need to be replaced with a coroutine function pointer toswift_deletedCalleeAllocatedCoroutineMethodError.Previously, though, an attempt was made to replace them with an async function pointer to that method. No such entity exists.
Here, this is fixed so they are replaced with a coroutine function pointer.
Scope: Affects the experimental CoroutineAccessors feature.
Issue: rdar://148760489
Original PR: #80556
Risk: Low, only affects the coroutine accessors feature.
Testing: CI.
Reviewer: Arnold Schwaighofer ( @aschwaighofer )