Skip to content

[concurrency] Implement protocol witness thunking in SILGen for @execution(caller)/@execution(concurrent). #80622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Apr 8, 2025

This involved cleaning up and generalizing the work from f245389. I followed the same approach: hide the implicit parameter while we run things through translateArgument and friends and then put it back in manually.

As an additional benefit, I think I found a good place to put FunctionIsolation onto lowered AnyFunctionTypes that will not cause cycles in the evaluator since it is done in TypeLowering.

rdar://148785846

@gottesmm gottesmm requested review from ktoso and jckarter as code owners April 8, 2025 01:20
@gottesmm
Copy link
Contributor Author

gottesmm commented Apr 8, 2025

@swift-ci smoke test

…ution(caller)/@execution(concurrent).

This involved cleaning up and generalizing the work from
f245389. I followed the same approach: hide the
implicit parameter while we run things through translateArgument and friends and
then put it back in manually.

As an additional benefit, I think I found a good place to put FunctionIsolation
onto lowered AnyFunctionTypes that will not cause cycles in the evaluator since
it is done in TypeLowering.

rdar://148785846
@gottesmm gottesmm force-pushed the pr-9c92d645ac34f929bbaf39f2f26aa2e3e3acf5cb branch from 10dd745 to 04b845c Compare April 8, 2025 19:43
@gottesmm
Copy link
Contributor Author

gottesmm commented Apr 8, 2025

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge April 8, 2025 23:53
@gottesmm gottesmm merged commit f63be76 into swiftlang:main Apr 9, 2025
3 checks passed
@gottesmm gottesmm deleted the pr-9c92d645ac34f929bbaf39f2f26aa2e3e3acf5cb branch April 10, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant