[6.2] Cherry-pick recent CompatibilitySpan work #80680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
This actually depends on #80645 landing first. |
|
@swift-ci Please test |
|
You will also need to cherry-pick #80885 to ensure symbols have the correct names in the new build system as well. |
hborla
approved these changes
Apr 21, 2025
Swift CI tests visionOS, but PR testing does not. Oops.
This matches the flag that was added to the old build system in b0627e2 Addresses rdar://149410833
slavapestov
force-pushed
the
compatibility-span-6.2
branch
from
eda1c07 to
d62e385
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #80596, #80510, #80678
Description: Mostly cmake-adjacent changes for the
libswiftCompatibilitySpan.dyliblibrary, together with the right annotations needed to emit the$ld$previoussymbols intolibswiftCore.dylib. Also, update theSwiftStdlib 6.1availability macro with real version numbers now that Swift 6.1 has been officially released.Risk: Medium, just because cmake changes have caused problems in the past. Also the
$ld$previoussymbols will take effect if someone uses Span and builds for an older deployment target, but that shouldn't impact existing code.Reviewed by: @hborla