Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed urls for cloning repositories in README.md #82

Closed
wants to merge 2 commits into from

Conversation

AndreasPrang
Copy link

No description provided.

@qorcjftns
Copy link

git@github... works too, isnt it?

@asumaran
Copy link

asumaran commented Dec 3, 2015

@qorcjftns Yes it does

@AndreasPrang
Copy link
Author

for me it was not working:

$ git clone [email protected]/apple/swift-lldb.git lldb
fatal: repository '[email protected]/apple/swift-lldb.git' does not exist
$ git clone https://github.com/apple/swift-lldb.git lldb
Cloning into 'lldb'...
remote: Counting objects: 150034, done.
remote: Total 150034 (delta 0), reused 0 (delta 0), pack-reused 150034
Receiving objects: 100% (150034/150034), 37.41 MiB | 845.00 KiB/s, done.
Resolving deltas: 100% (115039/115039), done.
Checking connectivity... done.

@Mitame
Copy link
Contributor

Mitame commented Dec 3, 2015

This should be merged... [email protected]... requires that you have ssh support and that you have an ssh key linked on github. https://github.com... doesn't require any of this and just requires that you have access to github.com. It also means those without a github account can clone the repo.
This is mostly just an ease of use thing, but it would be nice for those of us that copy and paste or have encrypted ssh keys.

@nico
Copy link
Contributor

nico commented Dec 3, 2015

+1, the current URLs didn't work for me either, the URLs in this pull request do.

@bbashy
Copy link

bbashy commented Dec 3, 2015

@AndreasPrang You used the wrong SSH URL by the looks of it?

// yours
git clone [email protected]/apple/swift-lldb.git lldb

// readme's
git clone [email protected]:apple/swift-lldb.git lldb

Note the : not /

@yurikoles
Copy link

@bbashy those urls are from his previous PR #80. So @AndreasPrang is heroically fight his own error.
@AndreasPrang, please squash your commits. One commit is more than enough for this simple change.

So @AndreasPrang needs 3 commits to fix URLs, who will offer more?

@tkremenek
Copy link
Member

I have taken the suggestion of this pull request and committed a different answer in 15428fb which provides instructions for both people using https or SSH.

@tkremenek tkremenek closed this Dec 4, 2015
@gottesmm gottesmm mentioned this pull request Nov 25, 2016
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Aug 2, 2018
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Sep 17, 2018
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
TLS: Thread Local Storage

Signed-off-by: Daniel A. Steffen <[email protected]>
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
[RawSyntax] Fix pointer cast compiler errors
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024
…tlang#82)

motivation: consistentcy across RPM builders

changes:
* add docker-compose setup
* update rpmspec to use share metadata
* update Dockerfile to use updated rpmspec
* update build script to use updated Dockerfile and rpmspec
* add readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants