Losslessly Optimize Images #86
Conversation
|
I think you went too far with ones with red background |
|
Can you change the title of Pull Requests? You have a typo: |
|
Yeah, you will find that images that have strong 1 color channel prevalent areas tend to get pretty sever artifacts and color shift when doing this type of optimization. |
|
Problem is, these are already part of the git history... overwriting them will only make the repo larger. For docs it makes sense if they are hosted as web pages, but not really for tests/utils. |
|
Update: All changes have been reverted. Only Documentation images are now optimized since there is no quality loss. Thanks for the feedback. |
|
Committing something and immediately reverting it will bloat the repository, as was already mentioned. You should squash the commits into one so there's no unnecessary images added to history. Or just re-issue the PR using just the third commit, which is the only one that matters. |
…n_linux eliminate mach_task_self from linux_stubs
…n_linux eliminate mach_task_self from linux_stubs Signed-off-by: Daniel A. Steffen <[email protected]>
Cperf fixes oct 3
motivation: dedup more across RPM spec and scripts changes: * organize shared content in the a "Shared" directory * create several more ".inc" files that extract duplicate information across RPM spec, including the description and header * add symlinks to shared metadata and script so that the spec can also run easily outide docker * update docker compose scripts to use new directory structure * update Dockerfile optimization to be more resiliant by rewrting an bare-bone optimnization spec
Optimize all repository images using lossless compression (ImageOptim was used).