Skip to content

Run Multiple Times / Until Failure commands showing up for non-Swift tests #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
award999 opened this issue Aug 30, 2024 · 1 comment
Closed

Run Multiple Times / Until Failure commands showing up for non-Swift tests #1047

award999 opened this issue Aug 30, 2024 · 1 comment
Assignees
@plemarquand
Labels
bug Something isn't working

Comments

@award999
Copy link
Contributor

Describe the bug
You can see these new context menu commands for test cases that aren't swift tests

To Reproduce
Steps to reproduce the behavior:

  1. Open a workspace that has no Swift source (I had a Go workspace open)
  2. Go to the test explorer and right-click on a test case
  3. See commands
    Screenshot 2024-08-29 at 3 27 23 PM

NOTE When clicking the actually Swift extension activates and tries to run but fails obviously

Expected behavior
Hide these commands for non-Swift tests

Environment
All environments

Additional context
N/A
@award999 award999 added the bug Something isn't working label Aug 30, 2024
plemarquand added a commit to plemarquand/vscode-swift that referenced this issue Aug 30, 2024
@plemarquand
Show Swift test explorer context menu items only for Swift tests
8426036 
Keep a flattened list of swift Test Explorer test IDs in the context and
use a `when` clause on the context menu items to only show them on Swift
tests in the Text Explorer.

Issue: swiftlang#1047
@plemarquand plemarquand mentioned this issue Aug 30, 2024
Merged
plemarquand added a commit to plemarquand/vscode-swift that referenced this issue Aug 30, 2024
@plemarquand
Show Swift test explorer context menu items only for Swift tests
752e728 
Keep a flattened list of swift Test Explorer test IDs in the context and
use a `when` clause on the context menu items to only show them on Swift
tests in the Text Explorer.

Issue: swiftlang#1047
plemarquand added a commit to plemarquand/vscode-swift that referenced this issue Aug 30, 2024
@plemarquand
Show Swift test explorer context menu items only for Swift tests
2034a27 
Keep a flattened list of swift Test Explorer test IDs in the context and
use a `when` clause on the context menu items to only show them on Swift
tests in the Text Explorer.

Issue: swiftlang#1047
plemarquand added a commit that referenced this issue Sep 3, 2024
@plemarquand
Show Swift test explorer context menu items only for Swift tests (#1048)
303d4d2 
Keep a flattened list of swift Test Explorer test IDs in the context and
use a `when` clause on the context menu items to only show them on Swift
tests in the Text Explorer.

Issue: #1047
@plemarquand plemarquand added the needs verification Issue has been fixed, but requires verification before closing label Sep 3, 2024
@award999 award999 moved this from In Progress to Needs Verification in Swift Extension for Visual Studio Code Sep 11, 2024
@award999
Copy link
Contributor Author

Verified with be8372e

@github-project-automation github-project-automation bot moved this from Needs Verification to Done in Swift Extension for Visual Studio Code Sep 17, 2024
@award999 award999 removed the needs verification Issue has been fixed, but requires verification before closing label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plemarquand plemarquand

Labels
bug Something isn't working
Projects
Swift Extension for Visual Studio Code
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plemarquand @award999