Associate comment details on #expect w/ test issue #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
If a swift-testing #expect macro has preceding comments they are sent along with the expectation failure text as entries in the EventMessage array. Pull them out of the array so they don't appear as their own separate issues and append them to the actual issue text. Also fixes up some of the issue message colorization to be more consistent with how swift-testing behaves on the command line.
plemarquand
force-pushed
the
swift-testing-comment-parsing
branch
from
40f475d to
1cae5e1
Compare
award999
approved these changes
Aug 26, 2024
plemarquand
added
the
needs verification
|
Verified with d6c91dd |
matthewbastien
removed
the
needs verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a swift-testing
#expectmacro has preceding comments they are sent along with the expectation failure text as entries in the EventMessage array. Pull them out of the array so they don't appear as their own separate issues and append them to the actual issue text.Also fixes up some of the issue message colorization to be more consistent with how swift-testing behaves on the command line.