Fix Several Windows Debugging Issues #1083
Conversation
Fixes up some issues with Windows debugging found in the latest 6.0 toolchain: - Add Testing.dll to the PATH same as XCTest.dll - Don't append .exe when debugging testing binaries - Don't follow incorrectly created symlink at `.\build\debug`, point to real folder at the build triple path
plemarquand
force-pushed
the
windows-debugging-paths
branch
from
68021aa to
12a1415
Compare
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
|
This works around this issue in SwiftPM/Foundation: swiftlang/swift-package-manager#7965 |
There was a problem hiding this comment.
Looks good to me but can you review @matthewbastien since you're more familiar with this code
| if (this.platform === "win32" && path.extname(launchConfig.program) !== ".exe") { | ||
| if ( | ||
| this.platform === "win32" && | ||
| launchConfig.testType === undefined && |
There was a problem hiding this comment.
This works for now, but it would be nice to have a more "universal" way to determine if the .exe suffix needs to be added. I didn't anticipate this use case when I added this code. It could definitely use some work.
Perhaps we can have the auto-generated launch configurations use a target parameter instead of program, for example. That way the launch config can be used across all platforms while retaining the ability to target a specific executable for the tests.
I'm going to open up a separate issue from this since this needs to go in to unblock test debugging on Windows.
plemarquand
added
the
needs verification
|
Verified with 737ad69 |
matthewbastien
removed
the
needs verification
Fixes up some issues with Windows debugging found in the latest 6.0 toolchain:
.\build\debug, point to real folder at the build triple path