Add line terminator to XCTest filter regex #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
force-pushed
the
fix-xctest-suffixes
branch
from
3a75438 to
5dd4136
Compare
The regex to specify a specific XCTest to run did not specify that there should be no more text after the test ID. As a result, attempting to run a test like `testFoo` would also run a test in the same suite called `testFooBar`. Swift-testing tests do not have the same issue as their IDs include the function parentheses and argument labels, and no text can appear after the closing paren. Issue: swiftlang#1084
plemarquand
force-pushed
the
fix-xctest-suffixes
branch
from
5dd4136 to
f9df459
Compare
award999
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex to specify a specific XCTest to run did not specify that there should be no more text after the test ID. As a result, attempting to run a test like
testFoowould also run a test in the same suite calledtestFooBar.Swift-testing tests do not have the same issue as their IDs include the function parentheses and argument labels, and no text can appear after the closing paren.
Issue: #1084