Fix improper test argument simplification #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
force-pushed
the
fix-child-suite-runs
branch
3 times, most recently
from
a2b4fe2 to
c0c2a76
Compare
If the user tried to run a test suite that had as many tests as there are test suites in the module we improperly simplified the test arguments to run all suites in the module. This patch fixes this behaviour, and also introduces more robust tests. Issue: swiftlang#1183
plemarquand
force-pushed
the
fix-child-suite-runs
branch
from
c0c2a76 to
f1040a6
Compare
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
matthewbastien
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user tried to run a test suite that had as many tests as there are test suites in the module we improperly simplified the test arguments to run all suites in the module.
This patch fixes this behaviour, and also introduces more robust tests.
Issue: #1183