Add "auto" mode to sourcekit-lsp backgroundIndexing setting #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
Now that backgroundIndexing is no longer experimental it can be enabled by default in Swift 6.1. This patch evolves the `sourcekit-lsp.backgroundIndexing` setting to be an enum with three possible values, `true`, `false` or `auto`. The `true` and `false` options function as they did previously. The new `auto` setting will enable background indexing on Swift >= 6.1. To enable background indexing on Swift 6.0 the user must still set this setting to `true`, as this feature is experimental in 6.0.
plemarquand
force-pushed
the
background-indexing-auto-6.1
branch
from
9cf80b3 to
0882f49
Compare
|
cc @ahoppen |
award999
reviewed
Nov 28, 2024
award999
approved these changes
Nov 28, 2024
Co-authored-by: Mahdi Bahrami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that backgroundIndexing is no longer experimental it can be enabled by default in Swift 6.1.
This patch evolves the
sourcekit-lsp.backgroundIndexingsetting to be an enum with three possible values,true,falseorauto.The
trueandfalseoptions function as they did previously. The newautosetting will enable background indexing on Swift >= 6.1. To enable background indexing on Swift 6.0 the user must still set this setting totrue, as this feature is experimental in 6.0.