Use synchronize-request in LSP tests on 6.2
#1461
Conversation
The tests used `workspace/_pollIndex` to determine if sourcekit-lsp had finished indexing, however this hidden request was removed from sourcekit-lsp recently in favour of `workspace/_synchronize` Issue: swiftlang#1457
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
|
cc @ahoppen |
| "swift.sourcekit-lsp.serverArguments": [ | ||
| "--experimental-feature", | ||
| "synchronize-request", | ||
| ], |
There was a problem hiding this comment.
Instead of adding the to specify this as part of initializationOptions during the initialize request? As a general direction, I would like to move away from taking command line arguments to SourceKit-LSP.
There was a problem hiding this comment.
What does that look like? Adding "workspace/synchronize-request": true to the options here? https://github.com/swiftlang/vscode-swift/blob/main/src/sourcekit-lsp/LanguageClientManager.ts#L650
There was a problem hiding this comment.
It should be adding "experimentalFeatures": ["synchronize-request"] there. Though it would be nice to only enable that experimental feature for tests that need it. If that’s not possible, let me know and we can try to prioritize making the request non-experimental.
There was a problem hiding this comment.
Thanks, I've addressed this in #1463
The tests used
workspace/_pollIndexto determine if sourcekit-lsp had finished indexing, however this hidden request was removed from sourcekit-lsp recently in favour ofworkspace/_synchronizeIssue: #1457