Skip to content

load taskProviders after folder is ready #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

load taskProviders after folder is ready #387

wants to merge 2 commits into from

Conversation

aelam
Copy link
Contributor

@aelam aelam commented Aug 11, 2022 •
edited
Loading

I noticed the task list came out kinda randomly.
After I debugged the code, I found provideTasks is called in the very beginning before folderContext is ready

@swift-server-bot
Copy link

Can one of the admins verify this patch?

3 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@aelam aelam marked this pull request as ready for review August 11, 2022 11:57
@aelam aelam mentioned this pull request Aug 11, 2022
Merged
@adam-fowler
Copy link
Contributor

@swift-server-bot please test this

@adam-fowler
Copy link
Contributor

After I debugged the code, I found provideTasks is called in the very beginning before folderContext is ready

This is not strictly true. The task provider is setup which is then called whenever someone brings up the build task menu. I'm not sure what this fixes in the end. When you bring up the build task list before the projects have loaded, it will show nothing. Once a project has loaded it will show build tasks for that project

@aelam
Copy link
Contributor Author

aelam commented Aug 16, 2022

Sorry, this is a bug of a task explorer, there is no reload, the timing of loading the task list is only in the very beginning.

@aelam aelam closed this Aug 16, 2022
@aelam aelam deleted the wl_task_providing_after_folder_ready branch August 16, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelam @swift-server-bot @adam-fowler