Management of swiftinterface files #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
feature/swift-module
branch
from
209475f to
fbfb4f1
Compare
adam-fowler
commented
May 4, 2023
| @@ -1,6 +1,6 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.3.0 - 2023-05-02 | |||
| ## 1.3.0 - 2023-05-03 | |||
There was a problem hiding this comment.
This PR has caught my date update for the CHANGELOG
| (client: langclient.LanguageClient, cancellationToken: vscode.CancellationToken): Return; | ||
| }) { | ||
| if (!this.languageClient) { | ||
| ( |
There was a problem hiding this comment.
I cleaned up useLanguageClient a little because I was originally using this in the PR, but I'm not anymore. But the clean up is still valid I feel.
0xTim
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you right click on the
import moduletext you can jump to a cleaned up version of its swift interface file with documentation. Eventually I hope SourceKit-LSP will be able to do this for any symbol from a framework we don't have source code for.In the meantime this PR helps this process by first adding a readonly document provider and using this when displaying swift interface files. A middleware is added to the LSP client to redirect the swiftinterface files to the read-only document provider. This means of course the user can't edit the files but also has the added bonus that sourcekit-lsp will not try to compile them (and most likely complain). Secondly I have also associated the extension
.swiftinterfacewith the swift language so we get proper highlighting.