Fix version comparison #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
approved these changes
Oct 5, 2023
adam-fowler
pushed a commit
that referenced
this pull request
Oct 6, 2023
* fix-xctest-version-comparison * Fix all instances of version comparison
|
@adam-fowler This PR was merged, but I don't see the changes in main. What happened? 🤔 |
|
Err not sure what has happened here. I'll go check what I have locally. |
|
It is on main. Just after 1.5.2 changelog commit. |
|
Hmm never mind then, not sure what happened here. I also verified this works on 1.7.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript does not support operator overloading. What was happening when we compared two Version objects was that
toStringwas called on both sides and the strings were compared. Unfortunately the unit test wasn't catching this because the strings ended up being lexicographically ordered.This probably fixes several issues, but the one I was after is the Windows xctest path in the debug configuration being incorrect with a Swift 5.11 build because the
>= new Version(5, 7, 0)was returning false.