Skip to content

Make JSError conform to JSBridgedClass #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

MaxDesiatov
Copy link
Contributor

The lack of this conformance makes it impossible to attach catch callbacks to JSPromise when Failure: JSError, as catch methods have Failure: JSValueConstructible constraints.

The lack of this conformance makes it impossible to attach `catch` callbacks to `JSPromise`, as `catch` methods have `Failure: JSValueConstructible` constraints.
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 29, 2020
@MaxDesiatov MaxDesiatov requested a review from a team September 29, 2020 11:30
@github-actions
Copy link

github-actions bot commented Sep 29, 2020

Time Change: +439.25ms (2%)

Total Time: 15,722.75ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 199.25ms +2ms (1%)
Serialization/Write JavaScript string directly 195.25ms +0.5ms
Serialization/Swift Int to JavaScript 5,722.75ms +147.75ms (2%)
Serialization/Swift String to JavaScript 5,885.25ms +211.25ms (3%)
Object heap/Increment and decrement RC 3,720.25ms +77.75ms (2%)

performance-action

@j-f1
Copy link
Member

j-f1 commented Sep 29, 2020

Does it make sense to make JSError a bridged class to the JavaScript Error class?

@MaxDesiatov MaxDesiatov requested a review from j-f1 October 1, 2020 16:27
@MaxDesiatov MaxDesiatov changed the title Add missing JSValueConstructible on JSError Make JSError conform to JSBridgedClass Oct 1, 2020
@MaxDesiatov MaxDesiatov merged commit cb1aaf2 into main Oct 1, 2020
@MaxDesiatov MaxDesiatov deleted the jserror-jsvalueconstructible branch October 1, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants