Assert on queriedButton
not button
in the test
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test was meaningless as we didn't assert on the text content of
queriedButton
.I've also removed
addEventListener
because it doesn't actually work. Thebutton
instance is already deallocated by the time that test has finished, so the closure passed toaddEventListener
is released too. We need to find a way to run async tests like this, and I have a few thoughts, but this still needs to be explored.