Skip to content

Fix test part 4 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 20, 2020

This patch includes:

  • c74876a Fix C variadic parameter interpolation

    • Support va_list of musl named __isoc_va_list
    • Change to align parameters
      float is 8-bytes aligned on wasm32 and 8-bytes is greater than the alignment of Int. So the va_list storage should be explicitly aligned.
  • 29a89d7 Fix test/stdlib/Error.swift

    • Skip test cases that expect a crash
    • Skip willThrow test case because wasm doesn't support dynamic symbol loading. pointerToSwiftCoreSymbol uses dlsym.
  • a0f48aa Use wasmer instead of wasmtime

    • wasmer is a little faster than wasmtime 😄
    • The default singlepass backend has some bugs around memory access, so use cranelift backend instead. ba7116f
  • cf2b7ea Fix test/stdlib/FlatMapDeprecation.swift

    • Use target-typecheck-verify-swift instead to propagate target specific compiler flags
  • 7427540 test/stdlib/InputStream.swift.gyb

    • This test case requires sub-process, so disable at this time.
  • e525208 test/stdlib/Mirror.swift

    • Skip test cases that expect a crash
  • a7d49ca test/stdlib/Runtime.swift.gyb

    • Add arch(wasm32) condition to test 32bit memory layout
  • f371b79 test/stdlib/StringAPI.swift

    • Disable always failing test case

News

After this and swiftwasm/llvm-project#4 are merged, all test suites in test/stdlib succeed.

MaxDesiatov
MaxDesiatov previously approved these changes Mar 20, 2020
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

@kateinoigakukun kateinoigakukun marked this pull request as ready for review April 3, 2020 09:41
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff 👍

@kateinoigakukun kateinoigakukun merged commit 1f7bfed into swiftwasm:swiftwasm Apr 3, 2020
@kateinoigakukun
Copy link
Member Author

Now we should ensure that test/stdlib are passed on CI 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants