forked from swiftlang/swift
-
Notifications
You must be signed in to change notification settings - Fork 30
Fix test part 4 #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kateinoigakukun
merged 9 commits into
swiftwasm:swiftwasm
from
kateinoigakukun:katei/fix-test-part4
Apr 3, 2020
Merged
Fix test part 4 #451
kateinoigakukun
merged 9 commits into
swiftwasm:swiftwasm
from
kateinoigakukun:katei/fix-test-part4
Apr 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf09902
to
a0f48aa
Compare
MaxDesiatov
previously approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done 👍
MaxDesiatov
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff 👍
Now we should ensure that test/stdlib are passed on CI 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes:
c74876a Fix C variadic parameter interpolation
__isoc_va_list
float
is 8-bytes aligned on wasm32 and 8-bytes is greater than the alignment of Int. So the va_list storage should be explicitly aligned.29a89d7 Fix test/stdlib/Error.swift
willThrow
test case because wasm doesn't support dynamic symbol loading.pointerToSwiftCoreSymbol
uses dlsym.a0f48aa Use wasmer instead of wasmtime
cf2b7ea Fix test/stdlib/FlatMapDeprecation.swift
7427540 test/stdlib/InputStream.swift.gyb
e525208 test/stdlib/Mirror.swift
a7d49ca test/stdlib/Runtime.swift.gyb
f371b79 test/stdlib/StringAPI.swift
News
After this and swiftwasm/llvm-project#4 are merged, all test suites in
test/stdlib
succeed.