Skip to content

Revert thunk emission code completely #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2020
Merged

Revert thunk emission code completely #686

merged 2 commits into from
Apr 17, 2020

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Apr 16, 2020 •
edited
Loading

Revert #6 because LLVM can lower swifterror correctly now.

LLVM change is here https://reviews.llvm.org/D76049

@kateinoigakukun kateinoigakukun force-pushed the katei/revert-thin-to-thick branch from 2e51c2d to 834952d Compare April 16, 2020 13:35
@kateinoigakukun kateinoigakukun marked this pull request as ready for review April 16, 2020 13:37
@MaxDesiatov
Copy link

Could you link to a relevant LLVM change please?

@kateinoigakukun
Copy link
Member Author

D76049 is the patch. It's not new one 😄

MaxDesiatov
MaxDesiatov approved these changes Apr 16, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 🙂

@kateinoigakukun kateinoigakukun merged commit 3055180 into swiftwasm:swiftwasm Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov