This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Add imagine routing to the configuration #531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this affects the next upcoming version, not the current one. if i am not mistaken, the PR needs to go against the dev branch. |
|
indeed, @dbu is correct. But I can cherry pick it easily in that branch, there is no need to create a new PR. |
|
@wouterj did you ever cherry-pick this? once its moved to dev we can close this. afaik its needed for the MediaBundle 1.2 as we bumped the LiipImagineBundle |
|
Thanks for the docs, @JJK801! I'm sorry it took so long before I merged... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR contains documentation changes related to symfony-cmf/media-bundle#106
Thanks,
Jérémy