add MenuOptionsInterface docs

[mkoosej]

Q	A
Doc fix?	no
New docs?	yes
Applies to	dev
Fixed tickets	symfony-cmf/menu-bundle#197

[mkoosej]

Do you think here is a good place to mention the extension?

[dbu]

best would be the sonata admin chapter, but we seem to not have written that chapter for simple cms. yeah, lets add a .. tip:: at the end of the menu section saying that if you use sonata admin, there is the extension, and link to that section you are adding.

[wouterj]

You forgot to apply some of my comments (about line length and the headline). Did you not understand them, or did you simply forgot them?

Btw, you can simply push to the dev branch to update the PR, there is no need to open a new PR each time you want to update it.

[mkoosej]

I created a new one for the dev branch and I continue working on this PR.
I think I didn't fix the one that was about wrapping the lines. Can you help me with rst syntax of that cause I didn't understand the issue. If you find any other issue let me know.

[dbu]

here you need to delete some - characters so that the title line and the underline are the same length (with a fixed-width font display)

[dbu]

i ported the remaining comments from the old PR to here. hope its clearer now.

[dbu]

@mkoosej do you add the tip for simple cms admin in this PR or a separate one? and can you please add the bit in the cmf_menu configuration reference section? i would love to merge this PR soon so that the feature is properly documented when we release cmf 1.2.

[mkoosej]

@dbu Sorry for the hold up. I've been busy lately. I added the tip. I'm gonna add the configuration reference in a couple of hours.

[mkoosej]

@dbu I added the configuration reference too. Please review the changes especially the php and xml configuration part.

[dbu]

extra blank line

[dbu]

thanks, looks good. i added a couple of minor cleanup comments.

can you please adress those, and try to solve the merge conflict? and when its good, squash your commits into one?

[mkoosej]

Kinda unrelated. But I merged the remote the upstream branch to update my forked branch and it adds some more commits. If those will not cause issue I'm gonna squash all the commits into one.

[dbu]

squashed the commits and removed the merge + rebase issues in #548

thanks a lot for not only contributing but also documenting what you did, mkoosej!

[mkoosej]

@dbu I'm glad I could help. Although I was really bad at the documentation part :)

[wouterj]

Although I was really bad at the documentation part :)

You're not bad. It's just that you're new to the format, our standards and documentation in general. It's kind of like writing your first PHP script. If you see it like that, you did really well!