Suggestion: post slug should not been overidden

[ecourtial]

👋

In this line:

demo/src/Form/PostType.php

Line 82 in 7ca8927

if (null !== $postTitle = $post->getTitle()) {

We see that the slug is always created/updated if the title is not empty.
Issue: when editing a post which has already been published and indexed by search engines, it could trigger a side effect if you change the title.

I suggest:

if (null === $post->getSlug()) {
$post->setSlug($this->slugger->slug($post->getTitle())->lower());
}`

[bocharsky-bw]

Makes sense to me 👍

[javiereguiluz]

In a real application I'd 100% agree with you; here it might be debatable because it's a demo application that needs to be realistic but not a completely real app.

In any case, since the proposed change would be small and easier to understand to people reading the code, let's do it!

@ecourtial would you be willing to submit a pull request with this change? Thanks!

[ecourtial]

@javiereguiluz
Allright I will create the PR soon.

[ecourtial]

@javiereguiluz Done.

[javiereguiluz]

Fixed in #1338. Thanks!