Skip to content

[RFC] Add a new "name" field to User entity #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yceruto opened this issue Jan 22, 2017 · 4 comments
Closed

[RFC] Add a new "name" field to User entity #446

yceruto opened this issue Jan 22, 2017 · 4 comments

Comments

@yceruto
Copy link
Member

yceruto commented Jan 22, 2017

Following @javiereguiluz's comment: #439 (comment)

for the users I'd like to display people names instead of emails (so we might need to add a field in the user entity).

There is any privacy/security reasons to do that?
This should be named name or fullName?

What do you think?

@javiereguiluz
Copy link
Member

I agree with adding a fullName property in the User entity ... but not any other property, to keep things simple.

@yceruto
Copy link
Member Author

yceruto commented Feb 8, 2017

👍

@yceruto
Copy link
Member Author

yceruto commented Feb 8, 2017

This property should be optional or mandatory?

javiereguiluz added a commit that referenced this issue Feb 14, 2017
This PR was squashed before being merged into the master branch (closes #457).

Discussion
----------

Add fullName property to User entity

Implements #446

Others changes:
* Show full author name in all templates (#439 (comment))
* Use "Jane Doe" instead of "Anna" [RFC] !
* Updated fixtures and user commands.

| Posts Index | Post Comments |
| --- | --- |
| ![index](https://cloud.githubusercontent.com/assets/2028198/22749352/fe23ceb6-edfa-11e6-9667-a60d28c51c5c.png) | ![comments](https://cloud.githubusercontent.com/assets/2028198/22749387/2656157e-edfb-11e6-98ce-9cc7150cbb68.png) |

Commits
-------

4f590dd Add fullName property to User entity
@javiereguiluz
Copy link
Member

Closing it as fixed by #457.

sayjun0505 added a commit to sayjun0505/sym_proj that referenced this issue Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #457).

Discussion
----------

Add fullName property to User entity

Implements symfony/demo#446

Others changes:
* Show full author name in all templates (symfony/demo#439 (comment))
* Use "Jane Doe" instead of "Anna" [RFC] !
* Updated fixtures and user commands.

| Posts Index | Post Comments |
| --- | --- |
| ![index](https://cloud.githubusercontent.com/assets/2028198/22749352/fe23ceb6-edfa-11e6-9667-a60d28c51c5c.png) | ![comments](https://cloud.githubusercontent.com/assets/2028198/22749387/2656157e-edfb-11e6-98ce-9cc7150cbb68.png) |

Commits
-------

4f590dd Add fullName property to User entity
spider-yamet added a commit to spider-yamet/sym_proj that referenced this issue Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #457).

Discussion
----------

Add fullName property to User entity

Implements symfony/demo#446

Others changes:
* Show full author name in all templates (symfony/demo#439 (comment))
* Use "Jane Doe" instead of "Anna" [RFC] !
* Updated fixtures and user commands.

| Posts Index | Post Comments |
| --- | --- |
| ![index](https://cloud.githubusercontent.com/assets/2028198/22749352/fe23ceb6-edfa-11e6-9667-a60d28c51c5c.png) | ![comments](https://cloud.githubusercontent.com/assets/2028198/22749387/2656157e-edfb-11e6-98ce-9cc7150cbb68.png) |

Commits
-------

4f590dd Add fullName property to User entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants