Add a test for command ListUsers (test emails) #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
changed the title
Nek-
changed the title
ker0x
approved these changes
Jul 15, 2020
|
Thank you @ker0x for feedbacks. This is fixed. |
voronkovich
reviewed
Jul 31, 2020
Nek-
force-pushed
the
feature/email-test
branch
2 times, most recently
from
fc39410 to
924445d
Compare
|
@javiereguiluz rebased! |
javiereguiluz
force-pushed
the
feature/email-test
branch
from
924445d to
6fd129c
Compare
|
Maxime, thanks for providing this test and for your work in the review phase. Thanks to reviewers too! |
stof
reviewed
Jul 7, 2021
| protected function setUp(): void | ||
| { | ||
| if ('Windows' === \PHP_OS_FAMILY) { | ||
| $this->markTestSkipped('`stty` is required to test this command.'); |
There was a problem hiding this comment.
Moving this to the abstract class is wrong. Not all command tests require stty. And AFAICT, testing the list:users command will not require stty as it is not an interactive command.
There was a problem hiding this comment.
Mmmmm, you are right! Anybody willing to make a Pull Request to fix this? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command list user was not tested until now, and that's quite sad because it's one of the only parts of the code that actually sends an email. Symfony has some tools for testing emails, let's use them!
I also refactored a little bit of command testing since there was an identical piece of code between test cases. (instantiating the command)