Replace Travis and Appveyor by GitHub Actions #1171
Conversation
.github/workflows/lint.yaml
Outdated
| ./bin/console lint:yaml config --parse-tags | ||
|
|
||
| - name: Lint Twig templates | ||
| run: | |
There was a problem hiding this comment.
If you want to execute all linters steps, no matter there was an error in a previous linter step, you can declare an id deps on the composer update step and use:
| run: | | |
| if: always() && steps.deps.outcome == 'success' | |
| run: | |
on each steps.
So even if the previous step is failing, the next ones are executed and we get all the infos about what is wrong in the PR.
There was a problem hiding this comment.
Good idea! Let's do that. Thanks!
| run: composer global require --no-progress --no-scripts --no-plugins symfony/flex dev-main | ||
|
|
||
| - if: matrix.php-version != '8.0' | ||
| run: composer update |
There was a problem hiding this comment.
shouldn't the CI run with the locked dependencies instead ?
There was a problem hiding this comment.
@javiereguiluz maybe composer install ?
|
Here's a question about GitHub Actions: I guess we don't see the checks added to this PR because it's the PR where we adding them, so I only see the checks in my personal fork: https://github.com/javiereguiluz/demo/actions That's OK ... but why GitHub only runs the |
Because the ci workflow does only run on pushing new commits to master: while the lint one allows to run on any branch |
|
@ogizanagi Sorry I missed that! Thanks! |
|
And for a workflow to run on a PR, the workflow file must exist in the repository. new workflows are not running for PRs sent from a fork. |
javiereguiluz
force-pushed
the
github_actions
branch
from
251e214 to
4b59c62
Compare
|
This is now merged ... so the switch is complete 🎉 Maxime, Christophe and Oskar ... THANKS for your great help (and patience) here. I couldn't make this without your help. Thanks! 🙇 |
…javiereguiluz) This PR was squashed before being merged into the main branch. Discussion ---------- Removed friendsofphp/php-cs-fixer from dev dependencies We can remove this because we're now using PHP-CS-Fixer via a Docker image created by @OskarStark and run via GitHub Actions (see #1171) Commits ------- d36d83b Removed friendsofphp/php-cs-fixer from dev dependencies
…javiereguiluz) This PR was squashed before being merged into the main branch. Discussion ---------- Removed friendsofphp/php-cs-fixer from dev dependencies We can remove this because we're now using PHP-CS-Fixer via a Docker image created by @OskarStark and run via GitHub Actions (see symfony/demo#1171) Commits ------- d36d83b Removed friendsofphp/php-cs-fixer from dev dependencies
…javiereguiluz) This PR was squashed before being merged into the main branch. Discussion ---------- Removed friendsofphp/php-cs-fixer from dev dependencies We can remove this because we're now using PHP-CS-Fixer via a Docker image created by @OskarStark and run via GitHub Actions (see symfony/demo#1171) Commits ------- d36d83b Removed friendsofphp/php-cs-fixer from dev dependencies
No description provided.