[RFC] Run lint commands on TravisCI #485
Conversation
composer.json
Outdated
| @@ -25,7 +25,7 @@ | |||
| "symfony/monolog-bundle" : "^3.0", | |||
| "symfony/polyfill-apcu" : "^1.0", | |||
| "symfony/swiftmailer-bundle" : "^2.3", | |||
| "symfony/symfony" : "^3.2", | |||
| "symfony/symfony" : "dev-master", | |||
There was a problem hiding this comment.
depending on dev-master directly is a total no-go.
And depending of ^3.3@dev would make this PR unmergeable, as it would mean that the demo would be in a state where it cannot be released (depending on beta releases is fine, but not on the dev version)
There was a problem hiding this comment.
I agree. I think lint:xliff command will be available in Symfony 3.3 so let's just wait for it. Otherwise, I can remove xliff command to make this PR mergeable for now - we may add xliff linter later when it will be released. Wdyt?
There was a problem hiding this comment.
I would do the PR without xliff for now (and without changing dependencies), and add the xliff command once the demo is updated to 3.3.
Keeping the deps update in this PR will just be painful, as it will create conflicts with other PRs moving to Symfony 3.3 (we already have a PR migrating to Symfony 3.3 to use the new DI features)
There was a problem hiding this comment.
Great, I updated PR. Thanks!
This reverts commit f2b5581.
|
@bocharsky-bw very nice! I love these little linters (and soon we'll add "lint:xliff" too!) |
…reguiluz) This PR was merged into the master branch. Discussion ---------- [RFC] Run lint commands on TravisCI Commits ------- cb6c5c8 Make the linted resources less restrictive (to lint TwigBundle templates too) c010b76 Used the bundle notation 6a08a12 Also lint Yaml and Twig files in CodeExplorerBundle 10d44f9 Remove lint:xliff command from TravisCI a267189 Revert "Upgrade Symfony to dev-master" 0fa6847 Run lint commands on TravisCI f2b5581 Upgrade Symfony to dev-master
No description provided.