Conform to Twig coding standards #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Something that our PHP CS Fixer doesn't cover |
|
👍 |
|
I hate this and it looks ugly ... but it's the standard, so let's merge this! Thanks @michaelperrin! |
javiereguiluz
added a commit
that referenced
this pull request
Mar 30, 2017
This PR was merged into the master branch. Discussion ---------- Conform to Twig coding standards See http://twig.sensiolabs.org/doc/2.x/coding_standards.html: > Do not put any spaces before and after the opening and the closing of arrays and hashes. > Put one (and only one) space after the start of a delimiter ({{, {%, and {#) and before the end of a delimiter (}}, %}, and #}) I changed a `{%else%}` to `{% else %}` on this point. Commits ------- 3d5fb91 Conform to Twig coding standards
|
Thanks @javiereguiluz! I agree with you, that doesn't really look better, but it's the standard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://twig.sensiolabs.org/doc/2.x/coding_standards.html:
I changed a
{%else%}to{% else %}on this point.