Moving assets into a root directory for simplicity #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good practices, I approve. |
20uf
approved these changes
Jul 2, 2017
ghost
approved these changes
Jul 2, 2017
yceruto
approved these changes
Jul 2, 2017
javiereguiluz
approved these changes
Jul 3, 2017
|
The new structure looks great! Thanks Ryan. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 3, 2017
…erryan) This PR was merged into the master branch. Discussion ---------- Moving assets into a root directory for simplicity I'd like to see `assets/` put at the root directory, instead of inside `app/Resources` (which is really specific to the framework). It's a bit simpler, and I think in Flex, it will need to be this way. Btw, the changes to the `web/build/*` files is due to a small, internal change in Encore 0.9.0 - e.g. https://github.com/symfony/symfony-demo/compare/master...weaverryan:move-assets?expand=1#diff-0d9100b0501984c386980f99e9fdb4b2 Cheers! Commits ------- 6f22715 Moving assets into a root directory for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to see
assets/put at the root directory, instead of insideapp/Resources(which is really specific to the framework). It's a bit simpler, and I think in Flex, it will need to be this way.Btw, the changes to the
web/build/*files is due to a small, internal change in Encore 0.9.0 - e.g. https://github.com/symfony/symfony-demo/compare/master...weaverryan:move-assets?expand=1#diff-0d9100b0501984c386980f99e9fdb4b2Cheers!