Remove useless PhpDoc comments and minor improvements #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@20uf I think I understand your downvote ... but don't be afraid because this won't break PHPStorm autocompletion. Most of these annotations are indeed useless because PHPStorm already can infer their types (through the constructor or other assignments). There's at least one Moreover, we now use PHP 7.1, so we can typehint everything and remove all PHPdoc. |
|
Thank you @yceruto. |
|
The typehint does not completely replace the annotations and the strong typing is not fully respected, for example the type of return is not specified. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 7, 2017
This PR was squashed before being merged into the master branch (closes #645). Discussion ---------- Add scalar typehints/return types Fixes #639 (comment) Commits ------- 5e93c07 Add scalar typehints/return types
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #645). Discussion ---------- Add scalar typehints/return types Fixes symfony/demo#639 (comment) Commits ------- 5e93c07 Add scalar typehints/return types
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #645). Discussion ---------- Add scalar typehints/return types Fixes symfony/demo#639 (comment) Commits ------- 5e93c07 Add scalar typehints/return types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locales()function.