Remove unnecessary configuration for controllers #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Nov 28, 2017
javiereguiluz
approved these changes
Nov 29, 2017
|
Thank you Yonel. |
javiereguiluz
added a commit
that referenced
this pull request
Nov 29, 2017
This PR was merged into the master branch. Discussion ---------- Remove unnecessary configuration for controllers This configuration is only necessary for service controllers that don't extend from `Controller` or `AbstractController`, which is not the case here. It is not clear in the recipe (in this sense) but the documentation is clear enough: > http://symfony.com/doc/current/controller.html#fetching-services-as-controller-arguments > If you're not using the default configuration, you can tag your service manually with `controller.service_arguments`. Commits ------- 1682f19 Remove unnecessary configuration for controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration is only necessary for service controllers that don't extend from
ControllerorAbstractController, which is not the case here.It is not clear in the recipe (in this sense) but the documentation is clear enough: