Upgrade @symfony/webpack-encore to 0.21.0 #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wenmingtang I've tested your pull request and it worked perfectly. Thanks a lot for contributing this nice improvement! It's merged now. Cheers! |
javiereguiluz
added a commit
that referenced
this pull request
Nov 15, 2018
This PR was merged into the master branch. Discussion ---------- Upgrade @symfony/webpack-encore to 0.21.0 see [Encore 0.21.0: Webpack 4 Support, Copy Files Support, WebpackEncoreBundle ](https://symfony.com/blog/encore-0-21-0-webpack-4-support-copy-files-support-webpackencorebundle) Commits ------- db5e658 Upgrade @symfony/webpack-encore to 0.21.0
Lyrkan
reviewed
Nov 15, 2018
| .addEntry('js/app', './assets/js/app.js') | ||
| .addEntry('js/login', './assets/js/login.js') | ||
| .addEntry('js/admin', './assets/js/admin.js') | ||
| .addEntry('js/search', './assets/js/search.js') | ||
| .addStyleEntry('css/app', ['./assets/scss/app.scss']) | ||
| .addStyleEntry('css/admin', ['./assets/scss/admin.scss']) | ||
| .splitEntryChunks() | ||
| ; |
There was a problem hiding this comment.
Looking at this a bit late but there is a missing Encore.enableSingleRuntimeChunk() or Encore.disableSingleRuntimeChunk() call in this file (https://symfony.com/blog/encore-0-21-0-webpack-4-support-copy-files-support-webpackencorebundle#new-runtime-js-file).
It doesn't make the build fail (for now) but displays a deprecation message when calling Encore:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see Encore 0.21.0: Webpack 4 Support, Copy Files Support, WebpackEncoreBundle