Add a new make:test command #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
feat/make-test
branch
2 times, most recently
from
6a7cef0 to
2f748c3
Compare
src/DependencyInjection/CompilerPass/MakeCommandRegistrationPass.php
Outdated
Show resolved
Hide resolved
wouterj
reviewed
Feb 4, 2021
weaverryan
reviewed
Feb 4, 2021
OskarStark
reviewed
Feb 4, 2021
weaverryan
reviewed
Feb 4, 2021
weaverryan
reviewed
Feb 4, 2021
| public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator) | ||
| { | ||
| $testClassNameDetails = $generator->createClassNameDetails( | ||
| $input->getArgument('name'), |
There was a problem hiding this comment.
Do we ever ask this interactively?
There was a problem hiding this comment.
Yes, it's delegated to the method in the abstract class.
dunglas
commented
Feb 5, 2021
| class MakeFunctionalTestTest extends MakerTestCase | ||
| { | ||
| public function getTestDetails() | ||
| { | ||
| yield 'functional_maker' => [MakerTestDetails::createTest( |
There was a problem hiding this comment.
This test is failing because of a bug in MakerTestCase. If a previous test (such as our new MakeTestTest) installs Panther, then the autoloader is confused for some reason and detects the dependency has always available even if it isn't, so the generated test extends PantherTestCase instead of WebTestCase. But when the test is executed in isolation, this time PantherTestCase isn't available, and it fails.
As this class is now deprecated, I don't think that it is worth it to fix MakerTestCase.
weaverryan
force-pushed
the
feat/make-test
branch
from
6c3e88d to
db16346
Compare
|
Thanks Kévin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #806.
As a result of discussions with @weaverryan, this PR introduces a new generic test maker. It allows creating unit (PHPUnit), integration/service (WebTestCase) and E2E/UI (PantherTestCase) tests.
make:unit-testandmake:functional-testhave been deprecated, but BC is preserved.