-
-
Notifications
You must be signed in to change notification settings - Fork 492
Add zenstruck/foundry #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
Thank you @kbond, Is this still "WIP"? I would be happy to merge this recipe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
I removed the WIP/RFC. I believe this will work as expected as is. Just a few outstanding questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
FYI, |
If there is a reason to add one, then yes. Im not sure what that reason is. What would you like to tell the user?
Will the config always be the same? If so, we can keep it. We are currently only using one config options, so we can also keep it simple.
You could add a link to your bundles docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
I added some config comments and a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Based on slack discussions with @weaverryan & @wouterj.
Foundry has the concept of auto-refreshing entities - prior to 1.9, this was disabled by default as there are caveats (entity changes silently lost). In 1.9, the caveats still exist but we were able to throw a helpful exception. We would now like auto-refreshing entities enabled by default but this would be a BC break in 1.x. A recipe to enable in 1.x was decided as the next best thing.
The double config is unfortunate but we couldn't think of a better way.
Likely we'll want a
post-install.txt
and probably some config comments?