Skip to content

Add zenstruck/foundry #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 12, 2021
Merged

Add zenstruck/foundry #908

1 commit merged into from
Mar 12, 2021

Conversation

kbond
Copy link
Member

@kbond kbond commented Mar 5, 2021

Q A
License MIT
Doc issue/PR symfony/symfony-docs#14731

Based on slack discussions with @weaverryan & @wouterj.

Foundry has the concept of auto-refreshing entities - prior to 1.9, this was disabled by default as there are caveats (entity changes silently lost). In 1.9, the caveats still exist but we were able to throw a helpful exception. We would now like auto-refreshing entities enabled by default but this would be a BC break in 1.x. A recipe to enable in 1.x was decided as the next best thing.

The double config is unfortunate but we couldn't think of a better way.

Likely we'll want a post-install.txt and probably some config comments?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Nyholm
Copy link
Member

Nyholm commented Mar 12, 2021

Thank you @kbond, Is this still "WIP"?

I would be happy to merge this recipe.

@kbond kbond changed the title [WIP][RFC] Add zenstruck/foundry Add zenstruck/foundry Mar 12, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@kbond
Copy link
Member Author

kbond commented Mar 12, 2021

I removed the WIP/RFC. I believe this will work as expected as is. Just a few outstanding questions:

  1. Should I add a post-install.txt?
  2. Should the double config be handled differently or comments added for an explaination?
  3. Any other comments in the config?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@kbond
Copy link
Member Author

kbond commented Mar 12, 2021

FYI, zenstruck/foundry 1.9 is now released.

@Nyholm
Copy link
Member

Nyholm commented Mar 12, 2021

Should I add a post-install.txt?

If there is a reason to add one, then yes. Im not sure what that reason is. What would you like to tell the user?

Should the double config be handled differently or comments added for an explaination?

Will the config always be the same? If so, we can keep it. We are currently only using one config options, so we can also keep it simple.
It does not matter too much for me. I would do what @OskarStark suggestes.

Any other comments in the config?

You could add a link to your bundles docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@kbond
Copy link
Member Author

kbond commented Mar 12, 2021

I added some config comments and a post-install.txt for review.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ghost ghost merged commit 45a2d98 into symfony:master Mar 12, 2021
@kbond kbond deleted the add-foundry branch March 12, 2021 14:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants