Fix recipe for phpunit #952
Conversation
ghost
deployed
to
| @@ -25,12 +25,9 @@ | |||
| </whitelist> | |||
| </filter> | |||
|
|
|||
| <!-- Run `composer require symfony/phpunit-bridge` before enabling this extension --> | |||
There was a problem hiding this comment.
This removes any diff between phpunit.xml.dist shipped by simple-phpunit vs phpunit recipes.
Without this change, what ppl get is random, leading to the deprecation report being unavailable.
| if (is_file(dirname(__DIR__).'/vendor/phpunit/phpunit/phpunit')) { | ||
| define('PHPUNIT_COMPOSER_INSTALL', dirname(__DIR__).'/vendor/autoload.php'); | ||
| require PHPUNIT_COMPOSER_INSTALL; | ||
| PHPUnit\TextUI\Command::main(); |
There was a problem hiding this comment.
Is this the real significant portion of this PR? Could you explain a bit further?
There was a problem hiding this comment.
This is the only possible fix for #936
There was a problem hiding this comment.
I see how there is no PHP file in phpunit to directly require. And so, you've mimicked their phpunit executable.
| <include> | ||
| <directory suffix=".php">src</directory> | ||
| </include> | ||
| </coverage> |
There was a problem hiding this comment.
Note to others: changes made to the schema for PHPUnit 9.
| @@ -6,7 +6,6 @@ | |||
| "tests/": "tests/" | |||
| }, | |||
| "gitignore": [ | |||
| ".phpunit", | |||
There was a problem hiding this comment.
Why .phpunit has been removed from .gitignore? I don't think that directory should be committed to the application source code, in my case it contains 2600+ files...
There was a problem hiding this comment.
Because now we prefer using the binary from PHPUnit (which does not create .phpunit folder) instead the binary from Symfony PHPUnit bridge (simple-phpunit).
So adding .phpunit in .gitignore is not useful anymore.
| <server name="SYMFONY_PHPUNIT_REMOVE" value="" /> | ||
| <server name="SYMFONY_PHPUNIT_VERSION" value="8.5" /> | ||
| --> | ||
| <server name="SYMFONY_PHPUNIT_VERSION" value="9.5" /> |
There was a problem hiding this comment.
Symfony 5.3 requires php 7.2. But phpunit 9.5 requires php 7.3. So PHP 7.2 users won't be able to run phpunit by default or am I misunderstanding this?
There was a problem hiding this comment.
PHP 7.2 is EOL so it shouldn't be maintained anymore IMHO
Fix #936
Fix symfony/symfony#41409 and symfony/symfony#41471